Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang experimental dep #4177

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update golang experimental dep #4177

merged 3 commits into from
Oct 6, 2023

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Oct 5, 2023 •
edited
Loading

Tracking issue

N/A

Describe your changes

See PR title, this update includes a breaking change to the slices.SortFunc function signature.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

N/A

Note to reviewers

N/A

@katrogan
Update golang experimental dep
4da0428 
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan
go mod tidy
37f608e 
Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c88f8f5) 58.97% compared to head (7d50334) 59.30%.
Report is 1 commits behind head on master.

❗ Current head 7d50334 differs from pull request most recent head f3055bb. Consider uploading reports for the commit f3055bb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
+ Coverage   58.97%   59.30%   +0.32%     
==========================================
  Files         619      550      -69     
  Lines       52804    39692   -13112     
==========================================
- Hits        31140    23538    -7602     
+ Misses      19180    13834    -5346     
+ Partials     2484     2320     -164
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flytepropeller/pkg/compiler/validators/utils.go 63.30% <100.00%> (+0.11%) ⬆️

... and 555 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan
go mod tidy
f3055bb 
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan merged commit a18da03 into master Oct 6, 2023
40 checks passed
@katrogan katrogan deleted the prepare-renovate branch October 6, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eapolinario eapolinario eapolinario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katrogan @eapolinario